-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.xlib: disable tests for python 3.12 #325676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pynose
violates the license and will be removed. #325669
If you need nose
for testing, please disable tests in 3.12.
799862e
to
0d78821
Compare
Thanks for the heads-up @natsukium , I have modified the PR as you suggested. Also did the same to #325680 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wasn't the nose dependency simply removed? #325872
Oh yeah, sorry. 🤦 |
Successfully created backport PR for |
Description of changes
Since the default Python version was upgraded from
3.11
to3.12
, some packges broke which depend on Python packages not compatible with3.12
.xlib
requiresnose
, which does not support3.12
. The alternativepynose
(https://pypi.org/project/pynose/) does support3.12
, and does the same job.This fixes the build of
neofetch
(viaueberzug
) .Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.